Skip to content

Revert "python3Packages.rasterio: 1.3.9 -> 4"#281747

Merged
imincik merged 1 commit intomasterfrom
revert-rasterio-4
Jan 18, 2024
Merged

Revert "python3Packages.rasterio: 1.3.9 -> 4"#281747
imincik merged 1 commit intomasterfrom
revert-rasterio-4

Conversation

@imincik
Copy link
Contributor

@imincik imincik commented Jan 18, 2024 •
edited
Loading

Description of changes

rasterio version 4 doesn't exist. Package is failing to build with
this change.

release-test-4 version is some 9 years old branch !

This change was merged as part of #271586 in ee7f056 .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@imincik
Revert "python3Packages.rasterio: 1.3.9 -> 4"
237c9bd 
`rasterio` version 4 doesn't exist. Package is failing to build with
this change.
@imincik imincik requested a review from mweinelt January 18, 2024 10:25
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 18, 2024
@imincik
Copy link
Contributor Author

imincik commented Jan 18, 2024

I would be very happy to have some explanation from @mweinelt . I can't imagine the reason of making such change.

@kirillrdy
Copy link
Member

kirillrdy commented Jan 18, 2024

i assume that was automated, we should run ./maintainers/scripts/update-python-libraries and see if it updates it again, if so then we should add passthru.skipBulkUpdate = true

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 18, 2024
@imincik
Copy link
Contributor Author

imincik commented Jan 18, 2024

I confirm running

$ ./maintainers/scripts/update-python-libraries pkgs/development/python-modules/rasterio/default.nix

INFO:root:Updating packages...
INFO:root:Path /home/imincik/Projects/nix/nixpkgs/code/pkgs/development/python-modules/rasterio/default.nix: updated rasterio from 1.3.9 to 4
INFO:root:Finished updating packages.
INFO:root:1 package(s) updated

caused the change.

I don't want to add passthru.skipBulkUpdate = true to all packages which I maintain. I would be happier if such bulk changes would be properly reviewed by package maintainers. I haven't seen any review notification for this.

@kirillrdy
Copy link
Member

kirillrdy commented Jan 18, 2024

I confirm running

$ ./maintainers/scripts/update-python-libraries pkgs/development/python-modules/rasterio/default.nix

INFO:root:Updating packages...
INFO:root:Path /home/imincik/Projects/nix/nixpkgs/code/pkgs/development/python-modules/rasterio/default.nix: updated rasterio from 1.3.9 to 4
INFO:root:Finished updating packages.
INFO:root:1 package(s) updated

caused the change.

I don't want to add passthru.skipBulkUpdate = true to all packages which I maintain. I would be happier if such bulk changes would be properly reviewed by package maintainers. I haven't seen any review notification for this.

thats very good point, maybe we can fix updater to prevent upgrades to tag that has earlier created date ?

@ofborg ofborg bot requested review from das-g, nh2, nialov, r-burns, sikmir and willcohen January 18, 2024 11:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 18, 2024
@imincik
Copy link
Contributor Author

imincik commented Jan 18, 2024

maybe we can fix updater to prevent upgrades to tag that has earlier created date ?

Yes, this can help, but still, I think the review is a must.

@imincik imincik merged commit a9fbf33 into master Jan 18, 2024
@imincik imincik deleted the revert-rasterio-4 branch January 18, 2024 11:19
@kirillrdy
Copy link
Member

kirillrdy commented Jan 18, 2024

yes sorry I didn't reply to "review" portion of your comment.

maybe @mweinelt can answer how python-updates PR notify people.

as for this PR, without passthru.skipBulkUpdate = true update will happen again.

you can disable bulk updates and rely on ryan bot, or manually updating package, but I am hoping we can resolve it by then

@dotlambda
Copy link
Member

dotlambda commented Jan 18, 2024

we should add passthru.skipBulkUpdate = true

Why was this not done??

@imincik
Copy link
Contributor Author

imincik commented Jan 18, 2024 •
edited
Loading

we should add passthru.skipBulkUpdate = true

Why was this not done??

I hope in fix in update-python-libraries.py rather then adding this in packages because of update script bugs. But I am of course happy to add it if update script can't/wouldn't be fixed.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2024

I am not sure if that can be fixed in the update script without reducing it's reliability with repos that do not always create releases.

@nixos-discourse
Copy link

nixos-discourse commented Jan 30, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@nh2 nh2 Awaiting requested review from nh2

@nialov nialov Awaiting requested review from nialov

@sikmir sikmir Awaiting requested review from sikmir

@das-g das-g Awaiting requested review from das-g

@r-burns r-burns Awaiting requested review from r-burns

@willcohen willcohen Awaiting requested review from willcohen

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@imincik @kirillrdy @dotlambda @SuperSandro2000 @nixos-discourse @delroth